Skip to content

fix(NODE-4584): revert nested union type support (#3383) #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

fix(NODE-4584): revert nested union type support (#3383) #3392

wants to merge 13 commits into from

Conversation

@durran
Copy link
Member

@durran durran commented Aug 30, 2022

Description

Reverts the strict nested union types support.

What is changing?

Reverts #3349 and comments out the added test with link to original ticket.

Reopens NODE-4513

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4584 / NODE-4571

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

nbbeeken and others added 13 commits August 19, 2022 10:52
@nbbeeken
test(NODE-4565): skip Network error on Monitor check (#3374)
5d004f2
@durran
test(NODE-4566): fix csfle pinned commit (#3377)
a3ee7e2
@aditi-khare-mongoDB
chore(NODE-4545): docs front page brand alignment (#3376)
2e47102
@baileympearson
feat(NODE-4484): add experimental support for disambiguatedPaths in c…
846365a 
…hange stream documents (#3365)
@nbbeeken
test(NODE-4574): skip zstd and snappy on gallium (#3379)
2eb68e6
@baileympearson
test(NODE-4479): adjust number of iterations of flakey test (#3378)
5f6e636
@baileympearson
test(NODE-4200): sync serverless:forbid changes in change stream unif…
3fe6a24 
…ied tests (#3380)
@dariakp
test(NODE-4534): unified SDAM test runner implementation (#3373)
6a86553
@durran
fix(NODE-4583): revert nested union type support (#3383)
7f94f0a
@baileympearson
test(NODE-4562): reduce macos coverage (#3381)
ffb6f93
@baileympearson
fix(NODE-4591): only set loadBalanced on handshake when explicitly set (
57e9f2d 
#3386)
@nbbeeken
chore(NODE-4293): update dependencies and compile driver on ts next (#…
6f52add 
…3384)
@addaleax
chore(NODE-4593): fix mongosh integration tests (#3387)
c245d82
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 30, 2022
nbbeeken
nbbeeken previously approved these changes Aug 30, 2022
View reviewed changes
@durran durran force-pushed the NODE-4584 branch 2 times, most recently from 299b431 to c245d82 Compare August 31, 2022 00:31
@durran durran closed this Aug 31, 2022
@durran durran deleted the NODE-4584 branch August 31, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nbbeeken nbbeeken nbbeeken left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@durran @nbbeeken @aditi-khare-mongoDB @baileympearson @dariakp @addaleax